Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3484] Insert standard goals #2424

Merged
merged 35 commits into from
Oct 31, 2024

Conversation

thewatermethod
Copy link
Collaborator

Description of change

A database migration to insert the new standard goals into the database

How to test

  • Confirm that the language matches the PDF provided by OHS
  • Confirm that the goals are selectable in the AR & RTR

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod
Copy link
Collaborator Author

Language updated with most recent 10/24

Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff on first goal:

image

@thewatermethod
Copy link
Collaborator Author

Diff on first goal:

image

Discussed with Adam, seems to be a quirk with the document he had, hyphen is correct

Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a couple of comments.

hash: md5(templateName),
createdAt: new Date(),
updatedAt: new Date(),
templateNameModifiedAt: new Date(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to capture new Date() in a variable, e.g. now and then use it for all of the dates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`, { transaction });
},
),
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error with the down migration.

Copy link
Collaborator

@kryswisnaskas kryswisnaskas Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could have something like this:

down: async (queryInterface) => queryInterface.sequelize.transaction(
    async (transaction) => {
      await prepMigration(queryInterface, transaction, __filename);
  
      await queryInterface.bulkDelete(
        'GoalTemplates',
        {
          creationMethod: CREATION_METHOD.CURATED,
          templateName: standardGoalTexts,
        },
        { transaction }
      );
    },
  ),  

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 26494f1

@thewatermethod thewatermethod merged commit 1135d96 into main Oct 31, 2024
11 checks passed
@thewatermethod thewatermethod deleted the mb/TTAHUB-3484/insert-standard-goals branch October 31, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants