Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prod] Fix error with goal template IDs, update postgres client #2330

Merged
merged 14 commits into from
Aug 27, 2024
Merged

[Prod] Fix error with goal template IDs, update postgres client #2330

merged 14 commits into from
Aug 27, 2024

Conversation

thewatermethod
Copy link
Collaborator

Description of change

  • Update the version of the postgres client used by the daily/on-demand backup system
  • Fix an error which caused goal template ID to be improperly passed through the system (this caused some FEI goals to be misidentified in the goal cards)

How to test

3318

  • Load prod data
  • Visit /recipient-tta-records/7695/region/7/rttapa and confirm the goals from the support case show their root causes
  • Verify there are no goals with responses and a null goalTemplateId

3337

Verify the backup runs correctly.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

dependabot bot and others added 14 commits August 21, 2024 19:08
@dependabot
Bump elliptic from 6.5.4 to 6.5.7
b759010 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7.
- [Commits](indutny/elliptic@v6.5.4...v6.5.7)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@thewatermethod
Fix deduping issue
4c1bb9b
@GarrettEHill
Update postgrescli_install.sh
8bd69a5
@GarrettEHill
Update yarn-audit-known-issues
e72d475
@GarrettEHill
Update yarn-audit-known-issues
640e115
@GarrettEHill
Update yarn-audit-known-issues
1891459
@thewatermethod
Fix existing non-FEI/response goals, fix typo in hook
025ab98
@thewatermethod
Merge remote-tracking branch 'origin/main' into mb/TTAHUB-3318/proper…
027ac89 
…ly-dedupe-fei
@thewatermethod
Mysteriously, update yarn audit
f41e3b7
@GarrettEHill
Merge pull request #2324 from HHS/dependabot/npm_and_yarn/elliptic-6.5.7
9e01576 
Bump elliptic from 6.5.4 to 6.5.7
@GarrettEHill
Merge pull request #2327 from HHS/TTAHUB-3337/update-postgres-client
745ba47 
[TTAHUB-3337] Update Postgres Client used for backup tasks
@thewatermethod
Merge remote-tracking branch 'origin/main' into mb/TTAHUB-3318/proper…
41a2bf0 
…ly-dedupe-fei
@thewatermethod
why not fix objectives too?
2bcd285
@thewatermethod
Merge pull request #2328 from HHS/mb/TTAHUB-3318/properly-dedupe-fei
50d9aa8 
[TTAHUB-3318] Attempt to correct goalTemplateId setting bug, properly dedupe FEI, correct **some** old data
@thewatermethod thewatermethod marked this pull request as ready for review August 27, 2024 19:47
@Jones-QuarteyDana Jones-QuarteyDana merged commit b309c47 into production Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jones-QuarteyDana Jones-QuarteyDana Jones-QuarteyDana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewatermethod @Jones-QuarteyDana @GarrettEHill