Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Remove null transactions from certain hooks, refactor objective collaborator hook to wait for results before committing #2264

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Jul 11, 2024

Description of change

  • Certain hooks allowed for "null" to be passed as the transaction option. It's possible that doing so would trigger an additional connection request between sequelize and our database, using one of our limited connection pool and triggering the error that led to the outage.
  • A certain hook (objective collaborators, being assigned when reports were approved) needed to be refactored as it was sometimes not waiting for all results to return before committing the transaction, which will throw an error and roll back all the operations.

How to test

  • To confirm that the null transactions aren't an issue any longer, you can observe the transaction logged in the backend logs or in the database in the audit log table.
  • Confirm that the case from TTAHUB-3172 is resolved.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review July 11, 2024 14:31
@kryswisnaskas kryswisnaskas merged commit 0236187 into production Jul 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants