Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3056] Close all r10 goals and complete objectives #2208

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

hardwarehuman
Copy link
Collaborator

Description of change

Region 10 wants to close all their active goals and set all the associated objectives to 'complete' so that they can transition to standardized goals.

How to test

If you run the SQL, you should get a result like:

        stat        | statcnt
--------------------+---------
 goals updated      |    2279
 objectives updated |    3604

And Region 10 should show only closed goals.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested

Before merge to main

  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@hardwarehuman hardwarehuman marked this pull request as ready for review June 17, 2024 14:47
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however can we just verify that if a Goal is already marked 'Closed' do we want to set its corresponding Objectives to 'Complete'? Right now we are not.

@hardwarehuman
Copy link
Collaborator Author

Looks good, however can we just verify that if a Goal is already marked 'Closed' do we want to set its corresponding Objectives to 'Complete'? Right now we are not.

@AdamAdHocTeam Per https://adhoc.slack.com/archives/C022R5301L4/p1718983502527129?thread_ts=1718982498.414239&cid=C022R5301L4 it's now updated to Complete all open objectives, not just the ones attached to Goals being closed in this PR

Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested again I now see all the linked objectives marked 'Complete'.

@hardwarehuman hardwarehuman merged commit bf0e171 into main Jun 21, 2024
10 checks passed
@hardwarehuman hardwarehuman deleted the TTAHUB-3056/r10-clear-all-goals-and-objs branch June 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants