Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use css parser instead of broken regex to extract urls #92

Merged
merged 2 commits into from
Jul 10, 2022
Merged

use css parser instead of broken regex to extract urls #92

merged 2 commits into from
Jul 10, 2022

Conversation

brbog
Copy link

@brbog brbog commented Jul 9, 2022

Fixes #91

Drop-in replacement for the current css parsing based on a (faulty) regex + added some extra tests.

@rzo1 rzo1 self-requested a review July 10, 2022 08:01
@rzo1 rzo1 self-assigned this Jul 10, 2022
@rzo1 rzo1 merged commit 5c57307 into HHN:master Jul 10, 2022
@rzo1
Copy link
Collaborator

rzo1 commented Jul 10, 2022

Thanks @brbog

@brbog brbog deleted the new-css-parser branch July 10, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzo1 rzo1 rzo1 approved these changes

Assignees

@rzo1 rzo1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: current css parsing implementation extracts wrong urls
2 participants
@brbog @rzo1