allow overriding the used parsers for binary, css, plain text #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89 .
At the moment I'm using a custom css parsing solution based on https://github.com/phax/ph-css . This update would allow me to avoid copying logic from the Parser class.
The reason for the custom css parser is that the current regex solution can 't cope with urls like:
background-image: url('leaves-medium (1920x1280).jpg')
. When not crawling binary data, this parsing might be irrelevant, so adding a dependency might not be in everyone's interest. I'll continue this train of thought in a separate comment.