feat: add support for multiple sql statements in single request #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forest
commented
Jun 11, 2023
| test "handles multi-statement requests", c do | ||
| assert {:ok, %Avalanche.Result{statement_handles: statement_handles} = result} = | ||
| Avalanche.run("begin transaction;select ?;select ? as two;commit;", [1, 2], [], c.options) | ||
|
|
There was a problem hiding this comment.
Note that for parameter substitution this is still treated as one statement.
There was a problem hiding this comment.
The result from run is for all statements together.
forest
commented
Jun 11, 2023
| assert result.status == :complete | ||
| assert length(statement_handles) == 4 | ||
|
|
||
| [sh1, sh2, sh3, sh4] = statement_handles |
There was a problem hiding this comment.
If you need the results from one or more of the statements, you need to know which one it was in the order, get that statement handle, and then call status to get the results.
forest
commented
Jun 11, 2023
| [sh1, sh2, sh3, sh4] = statement_handles | ||
|
|
||
| assert {:ok, %Avalanche.Result{rows: [%{"status" => "Statement executed successfully."}]}} = | ||
| Avalanche.status(sh1, [], c.options) |
There was a problem hiding this comment.
This is begin transaction;.
forest
commented
Jun 11, 2023
| assert {:ok, %Avalanche.Result{rows: [%{"TWO" => 2.0}]}} = Avalanche.status(sh3, [], c.options) | ||
|
|
||
| assert {:ok, %Avalanche.Result{rows: [%{"status" => "Statement executed successfully."}]}} = | ||
| Avalanche.status(sh4, [], c.options) |
forest
commented
Jun 11, 2023
|
|
||
| assert {:ok, %Avalanche.Result{} = result2} = | ||
| Avalanche.run( | ||
| "SELECT * FROM SNOWFLAKE_SAMPLE_DATA.WEATHER.DAILY_14_TOTAL LIMIT 1", |
There was a problem hiding this comment.
SNOWFLAKE_SAMPLE_DATA.WEATHER was removed by Snowflake.
pdgonzalez872
approved these changes
Jun 12, 2023
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: