Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nighlty build #173

Merged
merged 5 commits into from
Apr 28, 2022
Merged

fix nighlty build #173

merged 5 commits into from
Apr 28, 2022

Conversation

aliemjay
Copy link
Contributor

for -http: the latest nightly catched a soundness bug in Handler, FromRequest and Responder. Fix it by forcing the bound where Req: 'a on the associated types.

for -web: the same nightly version introduced regression in TAIT that specifically affects impls with borrowed request types. Most of the diff in -web is to workaround this regression:

  1. add the bound 'S: 's' on FromRequest impls.
  2. async block not captures req in Responder impls.
  3. middleware impl are impossible to be general enough (unless we abandon TAIT from the impl)

This regression should hopefully be fixed soon and we can then revert these workarounds.

upstream tracking issue: rust-lang/rust#95922

@fakeshadow
Copy link
Collaborator

Do you mind if we keep this PR open for a bit until the regression is fixed? Master branch is guaranteed only to build on 1.61.0-nightly (1bfe40d11 2022-03-18) therefore we can keep the code as is for now.(with middleware works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants