Models - Devise #2
Conversation
There was a problem hiding this comment.
Approved 🟢
Hi @HFG43
Congratulations! 🎉
Your project is complete! There is nothing else to say other than... it's time to merge it 
Highlights ✔️
- Rails project has a correct configuration ✅
- All models created with their validations ✅
- Controllers and Views ✅
- No linters errors ✅
- Pull request has a descriptive title and summary ✅
- Repository has a professional readme file ✅
Optional suggestions
- Please read the comments I have left below.
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
| class EntitiesController < ApplicationController | ||
| before_action :authenticate_user! | ||
| end |
There was a problem hiding this comment.
@HFG43 [OPTIONAL] I kindly suggest you rename this controller to align it with the name of the Expense model
| class EntityGroupsController < ApplicationController | ||
| before_action :authenticate_user! | ||
| end |
There was a problem hiding this comment.
@HFG43 [OPTIONAL] I kindly suggest you rename this controller to align it with the name of the ExpenseGroup model
Hi there!! I'm sending this pull request for you to review my code. Thanks in advance for your feedback!
Milestones 🎯:
📌 Add Log In & Sign Up functionalities using devise gem and letter opener
📌 Add Pages Controller with
Welcomepage📌 Add Models for
Entity,Groups,User, &Entity-groupPlease consider some commands and links should be added in the upcoming views and controllers
🎖️ General requirements:
Gitflow
No linter errors
Ensure the use of best practices and Ruby style