Add numpy version constraint for windows compatibility #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy 2.0 requires pybind 2.12, but despite matching this requirement the windows build seems to not work as the keras 3.3.3 library has seemingly been compile with numpy 1.x support only. Downgrading the version constraint to numpy < 2.0 fixes the issue for now. To be noted, that issue does not exist with Linux (and maybe macOS?) and this fixes should be revisited once official support for Keras 3 is added.
|
For reference:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 requires pybind 2.12, but despite matching this requirement
the windows build seems to not work as the keras 3.3.3 library has
seemingly been compile with numpy 1.x support only.
Downgrading the version constraint to numpy < 2.0 fixes the issue for
now. To be noted, that issue does not exist with Linux (and maybe
macOS?) and this fixes should be revisited once official support for
Keras 3 is added.