Update to new pyuvdata AnalyticBeam #339
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| .squeeze() | ||
| .transpose(3, 2, 1, 0) | ||
| ) | ||
| uvbeam = BeamInterface(uvbeam) |
There was a problem hiding this comment.
Is this really a UVBeam or can it also be an AnalyticBeam? If it can be either this name is very confusing.
There was a problem hiding this comment.
It's true that it can be an analytic beam, but since the name is API-facing, I don't want to change it here.
| @@ -1234,7 +1210,7 @@ def _handle_beam(uvbeam, **beam_kwargs): | |||
| return uvbeam | |||
| if Path(uvbeam).exists(): | |||
| return UVBeam.from_file(uvbeam, **beam_kwargs) | |||
| return AnalyticBeam(uvbeam, **beam_kwargs) | |||
| raise ValueError("uvbeam has incorrect format") | |||
There was a problem hiding this comment.
same issue here and other places -- don't use uvbeam as the variable name if it can be an AnalyticBeam
There was a problem hiding this comment.
OK, I've gone through and tried to change as many as I could that don't affect API
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## update-fftvis-api #339 +/- ##
====================================================
Coverage ? 93.05%
====================================================
Files ? 25
Lines ? 3328
Branches ? 556
====================================================
Hits ? 3097
Misses ? 124
Partials ? 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -78,7 +78,7 @@ tests = | |||
| pytest-cov>=2.5.1 | |||
| uvtools | |||
| vis = | |||
| fftvis>=0.0.7 | |||
| fftvis@git+https://github.com/tyler-a-cox/fftvis@mp_fftvis | |||
| line-profiler | |||
| matvis>=1.2.1 | |||
There was a problem hiding this comment.
I think the only thing we need to do is update the matvis version to >=1.3.0. Other than that, this all looks fantastic, thank you!
There was a problem hiding this comment.
Good catch, updated.
|
|
||
| with pytest.raises(TypeError): | ||
| beams = [BeamInterface(GaussianBeam(diameter=14.0), beam_type='power')] | ||
| print(beams) |
This updates instances of AnalyticBeam to use the new class in pyuvdata.
In particular, the
beams.pymodule is thoroughly simplified (i.e. all the poly-beam stuff). Also, the visibility simulators are simplified.