Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: update pypi publish action version #274

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

steven-murray
Copy link
Contributor

Use the non-deprecated link to the pypi publish action

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8f440e7) 92.73% compared to head (0b7b3e0) 92.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          24       24           
  Lines        3222     3222           
  Branches      706      706           
=======================================
  Hits         2988     2988           
  Misses        131      131           
  Partials      103      103           
Flag Coverage Δ
unittests 92.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to believe that this is a sensible and small change, but I get a little worried seeing specific versions of things pinned in code. Can you just quickly motivate why I shouldn't be worried about these changes?

.github/workflows/publish.yaml Show resolved Hide resolved
.github/workflows/publish.yaml Show resolved Hide resolved
Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and answering my questions!

@steven-murray steven-murray merged commit 565cb22 into main Oct 2, 2023
@steven-murray steven-murray deleted the update-publish-action branch October 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants