Use pyuvdata3 #464
Merged
Use pyuvdata3 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 97.10% 97.07% -0.03%
==========================================
Files 11 11
Lines 3587 3517 -70
==========================================
- Hits 3483 3414 -69
+ Misses 104 103 -1 ☔ View full report in Codecov by Sentry. |
tyler-a-cox
reviewed
Jul 11, 2024
There was a problem hiding this comment.
This looks good! I did have a question about whether we should continue supporting Python 3.9 if pyuvdata dropped support for it. I think that may actually be causing tests to fail on the hera_cal PR. We can continue to talk about it over there. Thanks @steven-murray
tyler-a-cox
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to force using pyuvdata 3, and therefore removes many instances where we had to catch warnings. It also fixes some numpy2 bugs.