Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for compatibility with future pyuvdata #459

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

bhazelton
Copy link
Member

Fixes a few places for compatibility with the upcoming changes to telescope metadata.

@bhazelton bhazelton requested a review from steven-murray May 14, 2024 17:01
steven-murray
steven-murray previously approved these changes May 15, 2024
Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good -- when we require pyuvdata 3 we can remove some lines.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.05%. Comparing base (0229ba1) to head (8a92b92).

Files Patch % Lines
hera_qm/firstcal_metrics.py 75.00% 1 Missing ⚠️
hera_qm/utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   97.10%   97.05%   -0.06%     
==========================================
  Files          11       11              
  Lines        3527     3533       +6     
==========================================
+ Hits         3425     3429       +4     
- Misses        102      104       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @bhazelton!

@steven-murray steven-murray merged commit f3b4a97 into main May 15, 2024
8 of 11 checks passed
@steven-murray steven-murray deleted the fix_future_pyuvdata branch May 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants