-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy2 compatibility #673
Open
bhazelton
wants to merge
8
commits into
main
Choose a base branch
from
numpy2_compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Numpy2 compatibility #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 34 34
Lines 5304 5308 +4
=======================================
+ Hits 5213 5217 +4
Misses 91 91 ☔ View full report in Codecov by Sentry. |
bhazelton
force-pushed
the
numpy2_compat
branch
from
November 13, 2024 21:08
d1d53fb
to
2027440
Compare
for support for numpy v2.0
drop deprecated mamba stuff
This warning doesn't show up except when running pytest with the `-W error` option. It's handled and doesn't indicate a real problem. It's quite unpredictable which test it will happen in. Also try to use context managers as much as possible and fix a couple other test issues.
bhazelton
force-pushed
the
numpy2_compat
branch
from
November 13, 2024 21:19
2027440
to
70278a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for numpy > 2.0, which requires changes to several dependencies:
psycopg
). This requires sqlalchemy>=2.0 and python>=3.10Motivation and Context
Types of changes
Checklist:
Other:
changes when this is merged.