Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy2 compatibility #673

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Numpy2 compatibility #673

wants to merge 8 commits into from

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Nov 13, 2024

Description

Add support for numpy > 2.0, which requires changes to several dependencies:

  • switch from psycopg2 to psycopg3 (package is actually called psycopg). This requires sqlalchemy>=2.0 and python>=3.10
  • Update other dependencies as needed
  • Drop testing against python 3.8 & 3.9, add testing against 3.11 & 3.12

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Schema change (any change to the SQL tables)
  • New feature without schema change (non-breaking change which adds functionality)
  • Change associated with a change in redis structure
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Other:

  • My code follows the code style of this project.
  • I understand the updates required onsite (detailed in the readme) and I will make those
    changes when this is merged.
  • Unit tests pass on site (This is a critical check, CI can differ from site).
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (265497c) to head (70278a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          34       34           
  Lines        5304     5308    +4     
=======================================
+ Hits         5213     5217    +4     
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

drop deprecated mamba stuff
This warning doesn't show up except when running pytest with the `-W error` option. It's handled and doesn't indicate a real problem.
It's quite unpredictable which test it will happen in.

Also try to use context managers as much as possible and fix a couple other test issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant