H8c

[jsdillon]

Description

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Schema change (any change to the SQL tables)
• New feature without schema change (non-breaking change which adds functionality)
• Change associated with a change in redis structure
• Breaking change (fix or feature that would cause existing functionality to change)
• Version change
• Build or continuous integration change
• Other

Checklist:

Bug fix checklist:

• My code follows the code style of this project.
• My fix includes a new test that breaks as a result of the bug (if possible).
• I understand the updates required onsite (detailed in the readme) and I will make those
  changes when this is merged.
• Unit tests pass on site (This is a critical check, CI can differ from site).
• I have updated the CHANGELOG.

Schema change:

• My code follows the code style of this project.
• I have added or updated the docstrings associated with my feature using the numpy docstring format.
• I have created an alembic version file to produce the schema change.
• I have tested looping upgrading and downgrading the alembic version and tests pass consistently.
• I have updated or created monitoring scripts and daemons so any new tables will be automatically populated (if appropriate).
• I understand the updates required onsite (detailed in the readme) and I will make those
  changes when this is merged.
• I have updated the schema documentation document with my changes (under docs/mc_definition.tex)
• I have added tests to cover my new feature.
• Unit tests pass on site (This is a critical check, CI can differ from site).
• I have updated the CHANGELOG.

New feature without schema change checklist:

• My code follows the code style of this project.
• I have added or updated the docstrings associated with my feature using the numpy docstring format.
• I understand the updates required onsite (detailed in the readme) and I will make those
  changes when this is merged.
• I have added tests to cover my new feature.
• Unit tests pass on site (This is a critical check, CI can differ from site).
• I have updated the CHANGELOG.

Change associated with a change in redis structure:

• My code follows the code style of this project.
• I have updated the redis dump in our test data to reflect the most recent structure onsite.
• I understand the updates required onsite (detailed in the readme) and I will make those
  changes when this is merged.
• Unit tests pass on site (This is a critical check, CI can differ from site).
• I have updated the CHANGELOG.

Breaking change checklist:

• My code follows the code style of this project.
• I have updated the docstrings associated with my change using the numpy docstring format.
• I have detailed any changes required to other HERA repos above and I will coordinate
  implementing the changes across all the repos.
• I understand the updates required onsite (detailed in the readme) and I will make those
  changes when this is merged.
• I have added tests to cover my changes.
• Unit tests pass on site (This is a critical check, CI can differ from site).
• I have updated the CHANGELOG.

Version change checklist:

• I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).

Build or continuous integration change checklist:

• If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.

Other:

• My code follows the code style of this project.
• I understand the updates required onsite (detailed in the readme) and I will make those
  changes when this is merged.
• Unit tests pass on site (This is a critical check, CI can differ from site).
• I have updated the CHANGELOG.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (f36c0dd) to head (ea4276a).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          34       34           
  Lines        5304     5304           
=======================================
  Hits         5212     5212           
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.