Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compatibility with pyuvdata 3.0 #669

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Fix for compatibility with pyuvdata 3.0 #669

merged 4 commits into from
Nov 13, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Jun 21, 2024

Description

  • Fix for some imports that will be changing in pyuvdata v3.0
  • pin numpy to <2.0 for now

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Schema change (any change to the SQL tables)
  • New feature without schema change (non-breaking change which adds functionality)
  • Change associated with a change in redis structure
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Other:

  • My code follows the code style of this project.
  • I understand the updates required onsite (detailed in the readme) and I will make those
    changes when this is merged.
  • Unit tests pass on site (This is a critical check, CI can differ from site).
  • I have updated the CHANGELOG.

@bhazelton bhazelton added the bug label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (056628a) to head (ab4abe2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   98.26%   98.28%   +0.01%     
==========================================
  Files          34       34              
  Lines        5304     5304              
==========================================
+ Hits         5212     5213       +1     
+ Misses         92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton changed the title Fix for compatibility with pyuvdata v3.0 Fix for compatibility with pyuvdata 3.0 and numpy 2.0 Nov 7, 2024
@bhazelton bhazelton changed the title Fix for compatibility with pyuvdata 3.0 and numpy 2.0 Fix for compatibility with pyuvdata 3.0 Nov 13, 2024
Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an easy one. Now we just have to handle numpy >=2 one day

@mkolopanis mkolopanis merged commit 57211be into main Nov 13, 2024
17 checks passed
@mkolopanis mkolopanis deleted the fix_pyuvdatav3 branch November 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants