Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site ops docs #667

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Update site ops docs #667

merged 2 commits into from
Jun 21, 2024

Conversation

bhazelton
Copy link
Member

Description

Update the site docs to list the cask machines as ones that should have their services restarted when hera_mc changes.

Also fixed some astropy future warnings that are new as of astropy 6.1.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Schema change (any change to the SQL tables)
  • New feature without schema change (non-breaking change which adds functionality)
  • Change associated with a change in redis structure
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Other:

  • My code follows the code style of this project.
  • I understand the updates required onsite (detailed in the readme) and I will make those
    changes when this is merged.
  • Unit tests pass on site (This is a critical check, CI can differ from site).
  • I have updated the CHANGELOG.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (4eb014b) to head (628d681).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   98.36%   98.36%   -0.01%     
==========================================
  Files          35       35              
  Lines        5332     5331       -1     
==========================================
- Hits         5245     5244       -1     
  Misses         87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton requested a review from mkolopanis June 20, 2024 22:10
@bhazelton
Copy link
Member Author

@plaplant a ping on this.

Copy link
Member

@plaplant plaplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the poke @bhazelton! This looks good to me.

@bhazelton bhazelton merged commit d23f81a into main Jun 21, 2024
17 checks passed
@bhazelton bhazelton deleted the update_site_ops_docs branch June 21, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants