Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observing around a certain RA #557

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Observing around a certain RA #557

wants to merge 7 commits into from

Conversation

Zhilei
Copy link
Member

@Zhilei Zhilei commented Jun 25, 2021

This is my first pass of adding an argument center_ra_deg in the correlator_control.py script.
There are several numbers hard-coded in. Please feel free to let me know if you have any suggestions.

@Zhilei Zhilei self-assigned this Jun 25, 2021
@Zhilei Zhilei requested a review from dannyjacobs June 25, 2021 17:46
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #557 (a259ee4) into main (8f862a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          35       35           
  Lines        5054     5054           
=======================================
  Hits         4918     4918           
  Misses        136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f862a3...a259ee4. Read the comment docs.

@Zhilei Zhilei force-pushed the galactic_center_obs branch from 5bbd21f to f987739 Compare June 29, 2021 16:39
Copy link
Contributor

@dannyjacobs dannyjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Zhilei,
This looks like it would work. Note that it assumes all necessary systems will be on and running at the relevant time. This is not necessarily the case though. If the desired time is in the day time the nodes will be switched off.

We're aiming to keep core operations software independent from research code as much as we can so we'll have to find another option for the LST2JD function. Pretty sure the Librarian does this when the correlator loads new files, we should find out what its using.
The correlator and M&C teams have continued to discuss the long-planned revamp for next season to hopeful resolve persistent instabilities and to enable baseline dependent averaging and fringe stopping. This will include changes to how the correlator starts up. Startup will be handled by the correlator not M&C. What will use this PR as a reference when formulating the next startup protocol.

~D

@Zhilei
Copy link
Member Author

Zhilei commented Jul 15, 2021

Hi Danny,
Thank you so much for the reply! I realized the ongoing correlator work which is related to this. I have called into one correlator telecon. I will keep an eye to the progress of the correlator LST locking work.
Do you think we should merge this PR or just leave it in the branch right now? Thanks!

@bhazelton
Copy link
Member

I think we want to leave it on a branch, I don't think we want to merge it here but it will be a good reference for the updates that are coming. We definitely do not want to take a hera_cal dependency in this code though, so a different source (astropy or pyuvdata) for that functionality will be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants