-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observing around a certain RA #557
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 35 35
Lines 5054 5054
=======================================
Hits 4918 4918
Misses 136 136 Continue to review full report at Codecov.
|
5bbd21f
to
f987739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Zhilei,
This looks like it would work. Note that it assumes all necessary systems will be on and running at the relevant time. This is not necessarily the case though. If the desired time is in the day time the nodes will be switched off.
We're aiming to keep core operations software independent from research code as much as we can so we'll have to find another option for the LST2JD function. Pretty sure the Librarian does this when the correlator loads new files, we should find out what its using.
The correlator and M&C teams have continued to discuss the long-planned revamp for next season to hopeful resolve persistent instabilities and to enable baseline dependent averaging and fringe stopping. This will include changes to how the correlator starts up. Startup will be handled by the correlator not M&C. What will use this PR as a reference when formulating the next startup protocol.
~D
Hi Danny, |
I think we want to leave it on a branch, I don't think we want to merge it here but it will be a good reference for the updates that are coming. We definitely do not want to take a hera_cal dependency in this code though, so a different source (astropy or pyuvdata) for that functionality will be required. |
This is my first pass of adding an argument
center_ra_deg
in thecorrelator_control.py
script.There are several numbers hard-coded in. Please feel free to let me know if you have any suggestions.