Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update to handle pstokes autos #970

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fix update to handle pstokes autos #970

merged 3 commits into from
Jul 31, 2024

Conversation

jsdillon
Copy link
Member

This fixes a bug introduced in #966 where you can't actually reverse polarizations like pI

jsdillon added 2 commits July 31, 2024 10:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jsdillon jsdillon requested a review from tyler-a-cox July 31, 2024 17:38
Copy link
Contributor

@tyler-a-cox tyler-a-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thanks @jsdillon!

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (64c1710) to head (56f06ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #970   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          31       31           
  Lines       11068    11069    +1     
=======================================
+ Hits        10754    10755    +1     
  Misses        314      314           
Flag Coverage Δ
unittests 97.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsdillon jsdillon merged commit 41dbed3 into main Jul 31, 2024
8 of 9 checks passed
@jsdillon jsdillon deleted the fix-update-pstokes branch July 31, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants