Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup to setup_method in nucal test #930

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

jsdillon
Copy link
Member

@jsdillon jsdillon commented Jan 29, 2024

EDIT: I've also editing the path handling where .uvh5 was replaced with .interleave_{inum}.uvh5, which affecting some of the path info in github actions. So now only .uvh5 in the basename can be replaced because I'm using code like:
iname = os.path.join(os.path.dirname(output_name), os.path.basename(output_name).replace('.uvh5', f'.interleave_{inum}.uvh5'))

@tyler-a-cox tyler-a-cox self-requested a review January 29, 2024 19:29
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d45df27) 97.17% compared to head (ff5d892) 97.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          23       23           
  Lines       10507    10507           
=======================================
  Hits        10210    10210           
  Misses        297      297           
Flag Coverage Δ
unittests 97.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-a-cox tyler-a-cox merged commit 45ed23c into main Jan 29, 2024
8 checks passed
@tyler-a-cox tyler-a-cox deleted the jsdillon-patch-1 branch January 29, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants