Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSTBIN for redundantly-averaged inpainted data #912

Merged
merged 23 commits into from
Sep 21, 2023

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Sep 20, 2023

Makes the following fixes:

  • Use the unique identifier baseline for a group when processing redundantly-averaged data, in the .where_inpainted. file.
  • trim the where-inpainted files in the same way as the calfiles and datafiles (removing empty nights)
  • 🤦🏻 write out the MAD data to the MAD file instead of the STD file...

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (98efdac) 97.18% compared to head (99803bb) 97.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files          23       23           
  Lines       10433    10444   +11     
=======================================
+ Hits        10139    10150   +11     
  Misses        294      294           
Flag Coverage Δ
unittests 97.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
hera_cal/lstbin_simple.py 97.62% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsdillon jsdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me, assuming tests pass!

@steven-murray steven-murray merged commit 54cfb9a into main Sep 21, 2023
@steven-murray steven-murray deleted the fix-where-inpainted-redavg branch September 21, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants