-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional fast sky-based calibration to abscal
module
#892
Open
tyler-a-cox
wants to merge
11
commits into
main
Choose a base branch
from
skycal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 97.16% 97.18% +0.02%
==========================================
Files 23 23
Lines 10638 10722 +84
==========================================
+ Hits 10336 10420 +84
Misses 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new sky-based calibration function to the
abscal
module. There are currently functions for performing traditional sky-based calibration (amp_logcal
andphs_logcal
), but both are quite slow as they involve matrix inversions. This new function,sky_calibration
, implements theStEfCal
algorithm (Salvini et al 2014) which scales as nants^2. Below is a time comparison between the existing abscal functions and the new methodAnd here is a comparison of the residuals of the two methods, showing nearly identical results for the two approaches
I also tested on H6C data using redundantly-calibrated, redundantly-averaged data as the sky model and found that the redundantly-calibrated data and sky-calibrated data agree quite well. Below are the delay-transformed redundantly calibration and sky-calibrated visibilities for a single baseline type.