Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional fast sky-based calibration to abscal module #892

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

tyler-a-cox
Copy link
Contributor

@tyler-a-cox tyler-a-cox commented Apr 30, 2023

This PR adds a new sky-based calibration function to the abscal module. There are currently functions for performing traditional sky-based calibration (amp_logcal and phs_logcal), but both are quite slow as they involve matrix inversions. This new function, sky_calibration, implements the StEfCal algorithm (Salvini et al 2014) which scales as nants^2. Below is a time comparison between the existing abscal functions and the new method

Screenshot 2023-04-30 at 3 04 39 PM

And here is a comparison of the residuals of the two methods, showing nearly identical results for the two approaches

Screenshot 2023-04-29 at 8 06 22 PM

I also tested on H6C data using redundantly-calibrated, redundantly-averaged data as the sky model and found that the redundantly-calibrated data and sky-calibrated data agree quite well. Below are the delay-transformed redundantly calibration and sky-calibrated visibilities for a single baseline type.

Screenshot 2023-11-03 at 9 11 31 PM

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b045b6e) 97.16% compared to head (5241467) 97.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   97.16%   97.18%   +0.02%     
==========================================
  Files          23       23              
  Lines       10638    10722      +84     
==========================================
+ Hits        10336    10420      +84     
  Misses        302      302              
Flag Coverage Δ
unittests 97.18% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-a-cox tyler-a-cox marked this pull request as ready for review May 1, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant