-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mint DOIs for resources and update metadata with that from DataCite #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove line breaks in text elements * Replace IsSupplementedBy with HasPart to ensure data table DOIs are included in JSON-LD
* Fixes #406 (hide button unless user is Admin or Coordinator).
* Fixes #403 (modify update_record_info for unfinished records).
* Move the subtitle for data tables and resource files to the title. * Improves results shown in DataCite Search and Google Dataset Search.
Revise HTML/BibTeX content of Cite widget and other changes
* Fix behaviour if record has multiple versions (previously incorrect). * Ensure sensible display for unfinished records with missing fields. * Take year from last updated date, different from publication year. * Allow for rivet URL argument when redirecting (fixes #413).
Removing it so it doesn't affect other tests.
Modified E2E tests to include an extra submission with resources in default data.
Also added tests for resource content negotiation
* Avoid calling switch_table so clipboard/json links are not mangled * Add filename to header * Fix issue with hide/show publication info
4 tasks
4 tasks
GraemeWatt
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work on this, @alisonrclarke! I'll merge now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a couple of other fixes from @GraemeWatt.
rivet
URL argument when redirecting #413Release Notes
Requires a new
doi
field to be added to thedata_resource
table:(See script)
Once this has been pushed to prod, the DataCite metadata should be updated and resources should be added, using the
doi-utils
command, probably in batches, e.g.:(Then
-s 2001 -e 4000
etc.)