Changes for new HCal segmentations #128
Conversation
There was a problem hiding this comment.
Hi @Archil-AD,
thanks a lot, very useful!
I didn't do a full review of the code but I looked at the overall structure and I have a couple of doubts about (1) why the fixed size SW clustering does not work (or did I miss it) for the phi-row segmentation and (2) whether rather than overriding the phi-theta HCAL positioning tool it might have been better to add the handling of the new phi-theta (non-theta-projective) readout in a new positioning tool - this is rather a question for @BrieucF
| @@ -17,6 +17,7 @@ | |||
| #include "detectorSegmentations/FCCSWGridModuleThetaMerged_k4geo.h" | |||
| #include "detectorSegmentations/FCCSWGridPhiTheta_k4geo.h" | |||
| #include "detectorSegmentations/FCCSWEndcapTurbine_k4geo.h" | |||
| #include "detectorSegmentations/FCCSWHCalPhiTheta_k4geo.h" | |||
There was a problem hiding this comment.
does this mean that one cannot use the phi-row segmentation for the fixed-size SW clustering? could this be added?
| @@ -27,90 +27,29 @@ StatusCode CellPositionsHCalPhiThetaSegTool::initialize() | |||
| error() << "Unable to locate Geometry service." << endmsg; | |||
| return StatusCode::FAILURE; | |||
| } | |||
| // get PhiTheta segmentation | |||
There was a problem hiding this comment.
I wonder if we could have kept the positioning tool for the phi-theta fictional grid readout as is (maybe useful for other detector concepts?) and create a separate positioning tool for the new phi-"theta" readout of the ALLEGRO HCal? Maybe more a question for @BrieucF. If we don't care about the positioning tools for the "grid-like" segmentations then we could also remove the CellPositionsECalBarrelPhiThetaSegTool.h/cpp ...
| @@ -51,12 +53,18 @@ StatusCode CreateFCCeeCaloNeighbours::initialize() | |||
| std::pair<int, int> extremaECalLastLayerTheta; | |||
| int ecalBarrelId = -1; // index of ecal barrel in segmentation list | |||
| dd4hep::DDSegmentation::BitFieldCoder *decoderECalBarrel = nullptr; | |||
| dd4hep::DDSegmentation::FCCSWGridPhiTheta_k4geo *hcalBarrelSegmentation = nullptr; | |||
There was a problem hiding this comment.
same comment here, the code for the phi-theta grid was removed, should have we kept it and add just the handling of different HCal segmentations?
BEGINRELEASENOTES
ENDRELEASENOTES