Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Remove line breaks from BBcode, fix URLs without scheme in Linkify, add noreferrer #1775

Merged
merged 2 commits into from
May 23, 2021

Conversation

Oha-you
Copy link
Contributor

@Oha-you Oha-you commented May 23, 2021

Fixes these issues:

  1. Extra <br> tags are added to forum quotes and youtube embeds (which breaks formatting and Linkify behavior)
  2. Linkifier converted some text that shouldn't be a link, like "My.Little.House.HDTV". Since .house is a top level domain, it became a link. I disabled matching URLs that don't have a scheme (http/https/ftp and so on)
  3. It's best to use noopener noreferrer attributes to prevent official websites to see where the links have been posted

@HDVinnie HDVinnie merged commit 8ad0acc into HDInnovations:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants