Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Seedboxes can not be deleted #2141

Closed
Obi-Wana opened this issue Feb 28, 2022 · 1 comment · Fixed by #2144
Closed

[Bug] Seedboxes can not be deleted #2141

Obi-Wana opened this issue Feb 28, 2022 · 1 comment · Fixed by #2144
Assignees
@HDVinnie
Labels
Bug

Comments

@Obi-Wana
Copy link
Contributor

Describe the bug
Seedbox can not be deleted.
404 Page not found:
No query results for model [App\Models\Seedbox] 3, test, eyJpdiI6Ikt3U2huSXd6UWh0YUpQL29kME5YeFE9PSIsInZhbHVlIjoiK2RUU0dqNzJFaGhyUHBSZDB6Y1VBQT09IiwibWFjIjoiOWIyMTFjNTRlZmI3ZWJkOTViNzQxOGVhYTEyMTA0ZDMzNjc3MmI2NjgwMjRmM2E4Y2E2YmYwYjRhMjFiYTI5YSIsInRhZyI6IiJ9, 2022-02-28T06:55:52.000000Z, 2022-02-28T06:55:52.000000Z

To Reproduce
Steps to reproduce the behavior:

  1. Go to unit3d.site
  2. Go to my profile
  3. Create a seedbox with some IP, save it and then try to delete it
  4. See error

UNIT3D (please complete the following information):

  • UNIT3D Version: 6.x
@Obi-Wana Obi-Wana added the Bug label Feb 28, 2022
@Alkl58
Copy link
Contributor

Alkl58 commented Feb 28, 2022

Change this:

UNIT3D-Community-Edition/app/Http/Controllers/SeedboxController.php

Line 72 in 04ce4c6

protected function destroy(Request $request, Seedbox $id): \Illuminate\Http\RedirectResponse

to this:

protected function destroy(Request $request, $id): \Illuminate\Http\RedirectResponse

HDVinnie added a commit that referenced this issue Feb 28, 2022
@HDVinnie
fix: seedbox controller
1f970f1 
- closes #2141
@HDVinnie HDVinnie mentioned this issue Feb 28, 2022
Merged
Spheres-cu added a commit to Spheres-cu/UNIT3D-Community-Edition that referenced this issue Mar 26, 2022
@Spheres-cu @HDVinnie
@StyleCIBot @dependabot @Alkl58 @laravel-shift @innocente205 @MiM-MiM @LokiThor2021 @bccornfo
Update from original (#1)
ac5022e 
* fix: chat bots

* chore: phpdoc blocks

* Apply fixes from StyleCI

* update: laravel mail and notification views

* chore: update dependencies

* fix: dependency

* fix: type hints

* build(deps): bump follow-redirects from 1.14.5 to 1.14.7

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.5 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.5...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: private message controller type hint

* fix: keyword searching

* fix: top 10 queries

- deleted_at column removed as was only used in local

* update: changelog

* add: prevent too big bbcode font size

* Apply fixes from StyleCI

* update: dependencies

* update: torrent search components

* add: prevent too big bbcode font size

* Move `resources/lang` folder

* Rename test assertions

* Streamline `$commands` property

* Replace deprecated `HEADER_X_FORWARDED_ALL` constant

* Upgrade to Flysystem 3.0

* Shift core files

* Remove web.config

* Convert `optional()` to nullsafe operator

* Remove unnecessary `$model` property

* Convert route options to fluent methods

Laravel 8 adopts the tuple syntax for controller actions. Since the old options array is incompatible with this syntax, Shift converted them to use modern, fluent methods.

* Convert deprecated `$dates` property to `$casts`

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Adopt anonymous migrations

* Shift cleanup

* Apply fixes from StyleCI

* chore: lint

* update: auth config

* revert: route changes

* Apply fixes from StyleCI

* update: validation lang

* Apply fixes from StyleCI

* update: localization

* build(deps): bump nanoid from 3.1.30 to 3.2.0

Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.2.0.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.1.30...3.2.0)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: cleanup

* Apply fixes from StyleCI

* chore: lint

* add: bbcode img lazy loading

* Update TorrentController.php

Delete freeleech tokens before deleting the torrent.

* update: user controller

* update: user controller

- add import

* update: model

* chore: lint

* Apply fixes from StyleCI

* update: announce config

- add download slots

* Apply fixes from StyleCI

* add: download_slots migration

* Apply fixes from StyleCI

* update: announce controller

- adjust download slots logic

* update: announce config

* add: download slots to group settings

* fix: announce controller

- add status to select for moderation check

* update: email blacklist validator

* add: migration

* Apply fixes from StyleCI

* add: remove timed torrent buffs command

* update: remove timed torrent buffs command

* update: torrent api controller

* update: remove timed torrent buffs command

* update: torrent api controller

* update: torrent list view

* update: torrent general info partial

* fix: staff group edit view

* update: complete timed torrent buffs

* Update UserController.php

Remove history records before deleting user.

* Update PollController.php

Delete poll options when poll is deleted.

* Apply fixes from StyleCI

* Apply fixes from StyleCI

* update: torrent modals

* update: dependencies

* update: git updater

* Bugfix: helper.js:removeDots()
Fixed some TrueHD/Atmos issues of dots and order not gettinf fixed.
Cleaned up and fixed DD(+) EX

* Add missing space to the TrueHD Atmos replace.
Shouldn't have cause any issue with it missing,
safer and catches more edge cases including it.

* fix: request controller validation order

* Add Console Command to Sync Season and Episode Numbers

* Apply fixes from StyleCI

* update: tv mediahub

- properly link matched torrents

* update: symfony/dom-crawler

- fixes php8.1 deprecated warnings

* update: dependencies

* update: user controller

* update: tmdb service

* Apply fixes from StyleCI

* update: test case

* update: dependencies

* update: dependencies

* update: announce system

- add torrent_id to history table and search by that instead of long info_hashes

* Apply fixes from StyleCI

* update: readme

* update: security.md

* update: gitupdater

- php 8.1

* fix: type hints

* Apply fixes from StyleCI

* fix: type hints

* update: torrent list search view

* update: torrent list search component

* fix: graveyard search component

* fix: rss controllers return type hints

* update: nerd bot

* Apply fixes from StyleCI

* fix: user model

* update: livewire config

* update: composer dependencies

* Apply fixes from StyleCI

* update: composer dependencies

* update: npm dependencies

* fix: HDInnovations#2116

- closes HDInnovations#2116

* fix: torrent cards view

- game meta

* (Update) Improve readability of user groups with enums (HDInnovations#2120)

Co-authored-by: HDVinnie <[email protected]>
Co-authored-by: lokithor <[email protected]>

* Apply fixes from StyleCI

* update: user groups enums

- add license

* update: auto group command

* update: dependencies

* update: peer connectivity check

* fix: game meta

- closes HDInnovations#2123

* remove: old files

* add: emoji picker

* Apply fixes from StyleCI

* update: flush ghost peers command

* update: flush ghost peers controller

* update: torrent controller

* update: user controller

* update: top 10 component

* update: torrent card search component

* update: torrent list search component

* update: history model

* update: torrent model

* update: user model

* update: post edit view

* update: webpack.mix.js

* update: configs

* update: composer.json

* update: torrent history queries

* update: dependencies

* fix: HDInnovations#2128

- closes HDInnovations#2128

* Apply fixes from StyleCI

* (Fix) certified banker badge (HDInnovations#2137)

* (Fix) Hidden User can't see himself in Peerlist (HDInnovations#2139)

* fix: seedbox controller

- closes HDInnovations#2141

* fix: achievements doc blocks

* update: bots

* update: graveyard command

- bump and temp fl resurrected torrents to help them get more seeds.

* update: commands

* update: helpers

* Apply fixes from StyleCI

* update: tmdb service

* update: dependencies

* update: email validator

* update: auditable trait

* update: repositories

* update: providers

* Apply fixes from StyleCI

* update: notifications

* update: models

* update: achievement unlocked listener

* fix: movie job

* update: middleware

* update: livewire components

* Apply fixes from StyleCI

* update: controllers

* Apply fixes from StyleCI

* fix: bbcode

- closes HDInnovations#2136

* update: configs

* (Fix) Race Condition Downloading Torrent

* (Fix) Hide Uploader Name in Peer & History List when Uploaded as Anonymous

* fix: type hint

* fix: route service provider

* add: purgecss

* add: swal confirmation on fl tokens

* optimize: torrent list search

- removes tooltips for title attr
- temp removed activity icons
- speeds up load time greatly

* update: issue template

* refactor: adopt new helpers in laravel 9

* Apply fixes from StyleCI

* update: preload placeholder

* fix: user controller

- whoops

* Apply fixes from StyleCI

* update: preloading script

* Apply fixes from StyleCI

* update: dependencies

* update: configs

* update: issue template

* update: issue template

* fix: issue template

* update: userbar to show download slots

* fix: socket.io

- this makes it so socket.io only loads on home page where its needed for chatbox and not globally which was causing socket.io to load on all pages when it was not even needed. Thus a performance increase now.

* Apply fixes from StyleCI

* update: home page

* update: exception handler

* Apply fixes from StyleCI

* update: torrent api controller

* update: phpunit workflow

* fix: phpunit workflow

* update: phpunit workflow

- add redis

* update: phpunit workflow

* update: phpunit workflow

* update: phpunit.xml

* fix: phpunit.xml

- avoids middleware errors because these are tests from console

* update: tests

* Apply fixes from StyleCI

* update: tests

* update: forum controller test

* (Update) Audit index and controller (HDInnovations#2159)

* fix: HDInnovations#2163

- closes HDInnovations#2163

* update: twostep trait

* update: rss

* fix: HDInnovations#2158

- closes HDInnovations#2158

* Apply fixes from StyleCI

* update: configs

* update: dependencies

* (Update) UserController.php (HDInnovations#2161)

- Eliminate possible race condition, clear temporary files after use, parameterize paths, amalgamate sql queries.

* bump: unit3d version

Co-authored-by: HDVinnie <[email protected]>
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alkl58 <[email protected]>
Co-authored-by: Shift <[email protected]>
Co-authored-by: innocente205 <[email protected]>
Co-authored-by: MiM-MiM <[email protected]>
Co-authored-by: Loki <[email protected]>
Co-authored-by: lokithor <[email protected]>
Co-authored-by: bccornfo <[email protected]>
Co-authored-by: Alkl58 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HDVinnie HDVinnie

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Release) 6.0.2 HDInnovations/UNIT3D-Community-Edition
3 participants
@HDVinnie @Alkl58 @Obi-Wana