Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12 cmake: simplify try_run result comparisons (#950) #952

Merged
merged 1 commit into from
Aug 24, 2021
Merged

1.12 cmake: simplify try_run result comparisons (#950) #952

merged 1 commit into from
Aug 24, 2021

Conversation

lrknox
Copy link
Collaborator

@lrknox lrknox commented Aug 23, 2021

Instead of looking at MATCHES 0 which runs a regex and returns a false
positive for any result such as 10, check if they are equal to 0.
Also quote 0 to avoid looking it up as a variable (which was left
behind prior to the fix to use ${RETURN_VAR} in the c_run macro).

Instead of looking at `MATCHES 0` which runs a regex and returns a false
positive for any result such as `10`, check if they are equal to `0`.
Also quote `0` to avoid looking it up as a variable (which was left
behind prior to the fix to use `${RETURN_VAR}` in the `c_run` macro).
@lrknox lrknox changed the title cmake: simplify try_run result comparisons (#950) 1.12 cmake: simplify try_run result comparisons (#950) Aug 23, 2021
@lrknox lrknox merged commit 9424fa2 into HDFGroup:hdf5_1_12 Aug 24, 2021
@lrknox lrknox deleted the 1_12_cmake-var-deref-issues branch August 27, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants