Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplifies Autotools type size checks #789

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Further simplifies Autotools type size checks #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,16 +1351,6 @@ CFLAGS="$H5_CFLAGS $AM_CFLAGS $CFLAGS"
## Checkpoint the cache
AC_CACHE_SAVE

## Write the confdefs.h header for checking sizes
cat >>confdefs.h <<\EOF
#include <stdbool.h>
#include <stdint.h>
#ifdef HAVE_UNISTD_H
#include <sys/types.h>
#endif
#include <time.h>
Copy link
Member Author

@derobins derobins Jun 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting time.h here messes up checks for clock_gettime and difftime. The rest of this processing is unnecessary since these headers are already included by default in AC_CHECK_SIZEOF processing.

EOF

AC_CHECK_SIZEOF( [int8_t])
AC_CHECK_SIZEOF( [uint8_t])
AC_CHECK_SIZEOF( [int_least8_t])
Expand Down Expand Up @@ -1389,12 +1379,12 @@ AC_CHECK_SIZEOF([uint_least64_t])
AC_CHECK_SIZEOF( [int_fast64_t])
AC_CHECK_SIZEOF( [uint_fast64_t])

AC_CHECK_SIZEOF([bool])
AC_CHECK_SIZEOF([bool], [], [#include <stdbool.h>])
AC_CHECK_SIZEOF([off_t])
AC_CHECK_SIZEOF([ptrdiff_t])
AC_CHECK_SIZEOF([size_t])
AC_CHECK_SIZEOF([ssize_t])
AC_CHECK_SIZEOF([time_t])
AC_CHECK_SIZEOF([time_t], [], [#include <time.h>])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdbool.h and time.h are not in the list of standard includes, so we set them separately and only when they are needed.


## Checkpoint the cache
AC_CACHE_SAVE
Expand Down