Fix warnings files #753
Merged
Fix warnings files #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmake runs iteratively, and the check_fortran_source_runs macros were clobbering a single output file that did not get updated on further configure iterations
lrknox
reviewed
Jun 15, 2021
| H5_CFLAGS="$H5_CFLAGS $(load_intel_arguments 18)" | ||
| fi | ||
|
|
||
| # intel <= 19 |
There was a problem hiding this comment.
Effect is to add -Wcheck for intel version 19 and lower? This is the reverse of the application of most of the compiler flags. It might be worth adding a comment explaining why this one is different.
derobins
approved these changes
Jun 15, 2021
lrknox
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addresses PR#751