-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes pre-C99 build and header cruft #700
Changes from all commits
ba9deae
00f9750
e997283
3eac585
71643b7
d242911
bc70f95
3d7ad8e
aeb16b7
765cb5b
18401fc
222242c
8d0cafa
d3694d1
1c7bcc2
70551e3
2dfc7db
71d2fbf
c8925f8
dd3e970
bb61990
2c2b368
be2ada6
439f3a8
649aa9b
3fa627f
0df36ec
d65c841
fc7eb21
130d491
544b320
bb66bb1
0c87055
33ca480
8f9fffa
a0fe592
92d5fcf
8e71a0e
f740f2e
802519c
7a3eba8
3b55859
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,7 +120,6 @@ CHECK_INCLUDE_FILE_CONCAT ("features.h" ${HDF_PREFIX}_HAVE_FEATURES_H) | |
CHECK_INCLUDE_FILE_CONCAT ("dirent.h" ${HDF_PREFIX}_HAVE_DIRENT_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("setjmp.h" ${HDF_PREFIX}_HAVE_SETJMP_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("stddef.h" ${HDF_PREFIX}_HAVE_STDDEF_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("stdint.h" ${HDF_PREFIX}_HAVE_STDINT_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("unistd.h" ${HDF_PREFIX}_HAVE_UNISTD_H) | ||
|
||
# Windows | ||
|
@@ -146,12 +145,9 @@ CHECK_INCLUDE_FILE_CONCAT ("strings.h" ${HDF_PREFIX}_HAVE_STRINGS_H) | |
CHECK_INCLUDE_FILE_CONCAT ("stdlib.h" ${HDF_PREFIX}_HAVE_STDLIB_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("memory.h" ${HDF_PREFIX}_HAVE_MEMORY_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("dlfcn.h" ${HDF_PREFIX}_HAVE_DLFCN_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("inttypes.h" ${HDF_PREFIX}_HAVE_INTTYPES_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("netinet/in.h" ${HDF_PREFIX}_HAVE_NETINET_IN_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("netdb.h" ${HDF_PREFIX}_HAVE_NETDB_H) | ||
CHECK_INCLUDE_FILE_CONCAT ("arpa/inet.h" ${HDF_PREFIX}_HAVE_ARPA_INET_H) | ||
# _Bool type support | ||
CHECK_INCLUDE_FILE_CONCAT (stdbool.h ${HDF_PREFIX}_HAVE_STDBOOL_H) | ||
|
||
## Check for non-standard extenstion quadmath.h | ||
|
||
|
@@ -237,11 +233,6 @@ macro (HDF_FUNCTION_TEST OTHER_TEST) | |
endif () | ||
endmacro () | ||
|
||
#----------------------------------------------------------------------------- | ||
# Check for these functions before the time headers are checked | ||
#----------------------------------------------------------------------------- | ||
HDF_FUNCTION_TEST (STDC_HEADERS) | ||
|
||
#----------------------------------------------------------------------------- | ||
# Check for large file support | ||
#----------------------------------------------------------------------------- | ||
|
@@ -416,13 +407,9 @@ HDF_CHECK_TYPE_SIZE (time_t ${HDF_PREFIX}_SIZEOF_TIME_T) | |
# Extra C99 types | ||
#----------------------------------------------------------------------------- | ||
|
||
# _Bool type support | ||
if (HAVE_STDBOOL_H) | ||
set (CMAKE_EXTRA_INCLUDE_FILES stdbool.h) | ||
HDF_CHECK_TYPE_SIZE (bool ${HDF_PREFIX}_SIZEOF_BOOL) | ||
else () | ||
HDF_CHECK_TYPE_SIZE (_Bool ${HDF_PREFIX}_SIZEOF_BOOL) | ||
endif () | ||
# Size of bool | ||
set (CMAKE_EXTRA_INCLUDE_FILES stdbool.h) | ||
HDF_CHECK_TYPE_SIZE (_Bool ${HDF_PREFIX}_SIZEOF_BOOL) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is currently unused in the library, but I'm leaving it in place for parity with other datatypes. |
||
|
||
if (MINGW OR NOT WINDOWS) | ||
#----------------------------------------------------------------------------- | ||
|
@@ -554,7 +541,6 @@ if (MINGW OR NOT WINDOWS) | |
foreach (other_test | ||
HAVE_ATTRIBUTE | ||
HAVE_C99_FUNC | ||
# STDC_HEADERS | ||
HAVE_FUNCTION | ||
HAVE_C99_DESIGNATED_INITIALIZER | ||
SYSTEM_SCOPE_THREADS | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,14 +88,6 @@ int main(void) | |
} | ||
#endif | ||
|
||
#ifdef STDC_HEADERS | ||
#include <stdlib.h> | ||
#include <stdarg.h> | ||
#include <string.h> | ||
#include <float.h> | ||
int main() { return 0; } | ||
#endif /* STDC_HEADERS */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the CMake "test" for certain C headers being present. It needs to be completely removed. |
||
|
||
|
||
#ifdef HAVE_ATTRIBUTE | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time headers are greatly simplified on modern POSIX systems. Those will be addressed in HDF5 in a later PR.