Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CMake code for doxygen and perl shell scripts #552

Merged
merged 163 commits into from
Apr 19, 2021
Merged

Cleanup CMake code for doxygen and perl shell scripts #552

merged 163 commits into from
Apr 19, 2021

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Apr 15, 2021

No description provided.

byrnHDF added 30 commits January 7, 2021 07:15
set (H5_PERL_FOUND YES)
endif ()
#-----------------------------------------------------------------------------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just use PERL_FOUND directly?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byrnHDF note this change is also in the PRs #523, 531, and 548 to merge long double changes to 1.12, 1.10, and 1.8, so I'm waiting for this answer to merge those, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just use PERL_FOUND directly?

There seemed to be a variable visibility issue, which these changes solved. I did not do any further investigating.

@lrknox lrknox merged commit b2c78e1 into HDFGroup:develop Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants