Move overflow macros from VFDs to H5FDpkg.h

[derobins]

These are identical in all VFDs except the core VFD, so they've been moved to H5FDpkg.h and renamed:

* MAXADDR           -->     H5FD_MAXADDR
* ADDR_OVERFLOW     -->     H5FD_ADDR_OVERFLOW
* SIZE_OVERFLOW     -->     H5FD_SIZE_OVERFLOW
* REGION_OVERFLOW   -->     H5FD_REGION_OVERFLOW

[derobins]

Just to show that they are, in fact, identical...

#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* subfiling ioc */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* subfiling */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* ros3 */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* splitter */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* onion */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* direct *?
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* mirror */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* sec2 */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* log */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* hdfs */
#define MAXADDR          (((haddr_t)1 << (8 * sizeof(HDoff_t) - 1)) - 1) /* stdio */

#define MAXADDR          ((haddr_t)((~(size_t)0) - 1)) /* core */





#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* subfiling ioc */
#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* subfiling */
#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* splitter */
#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* direct */
#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* sec2 */
#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* log */
#define SIZE_OVERFLOW(Z) ((Z) & ~(hsize_t)MAXADDR) /* stdio */

#define SIZE_OVERFLOW(Z) ((Z) > (hsize_t)MAXADDR) /* core */




#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* subfiling ioc */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* subfiling */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* ros3 */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* splitter */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* direct */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* mirror */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* sec2 */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* log */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* hdfs */
#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || ((A) & ~(haddr_t)MAXADDR)) /* stdio */

#define ADDR_OVERFLOW(A) (HADDR_UNDEF == (A) || (A) > (haddr_t)MAXADDR) /* core */

[qkoziol]

Nice :-)

Nit: Might be sensible to put the H5FD_ prefix in for the core VFD macros.

[derobins]

Nice :-)

Nit: Might be sensible to put the H5FD_ prefix in for the core VFD macros.

They get CORE_ prefixes and are local to H5FDcore.c because they are different from all the other VFDs.