Fix failures in dtypes test on cygwin #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
added
Priority - 2. Medium ⏹
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
jhendersonHDF
commented
Nov 6, 2024
| @@ -6436,16 +6436,17 @@ test__Float16(void) | |||
| } | |||
|
|
|||
| if (is_little_endian) { | |||
| if (path->conv.u.lib_func != H5T__conv_noop) { | |||
There was a problem hiding this comment.
In at least cygwin, H5T__conv_noop (and some of the other functions used below) has a different address from path->conv.u.lib_func, so the two can't be compared directly. Instead, compare based on the conversion path name.
jhendersonHDF
commented
Nov 6, 2024
| @@ -5660,8 +5660,8 @@ H5T__path_find_real(const H5T_t *src, const H5T_t *dst, const char *name, H5T_co | |||
| old_npaths = H5T_g.npaths; | |||
|
|
|||
| /* Set a few convenience variables */ | |||
| new_api_func = (matched_path && conv->is_app && conv->u.app_func); | |||
There was a problem hiding this comment.
Add an additional check to prevent the no-op path from being considered a new conversion path, which had some odd side effects from replacing the path with a slightly different, new no-op path.
qkoziol
approved these changes
Nov 6, 2024
mattjala
approved these changes
Nov 7, 2024
derobins
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.