Add parallel cdash script to daily-build workflow #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 2. Medium ⏹
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
| sudo apt install libssl3 libssl-dev libcurl4 libcurl4-openssl-dev | ||
| sudo apt install gcc-12 g++-12 gfortran-12 | ||
| sudo apt install libaec0 libaec-dev | ||
| sudo apt-get install libopenmpi-dev |
There was a problem hiding this comment.
I'm sure it's just from copy pasting, but we really don't need pretty much any of these dependencies other than libopenmpi-dev.
And if we just install the MPI package, then this workflow isn't much different from the other ones that run parallel tests. Ideally we should be building OpenMPI and MPICH from source and then caching the results so we can sometimes skip the long build process if their head commit hasn't changed.
jhendersonHDF
approved these changes
Oct 31, 2024
lrknox
approved these changes
Nov 1, 2024
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Nov 4, 2024
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.