Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bin/restore to not delete checked-in files #5017

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix bin/restore to not delete checked-in files #5017

merged 1 commit into from
Oct 28, 2024

Conversation

derobins
Copy link
Member

@derobins derobins commented Oct 27, 2024 •
edited
Loading

This was not updated when we started checking in Perl-generated files

@derobins
bin/restore deleted checked-in files
0603d4a 
This was not fixed when we started checking in files that were
generated by the Perl scripts in bin
@derobins derobins added Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality labels Oct 27, 2024
@derobins derobins changed the title bin/restore deleted checked-in files Fix bin/restore to not delete checked-in files Oct 27, 2024
@derobins derobins merged commit d8953c0 into HDFGroup:develop Oct 28, 2024
61 checks passed
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@derobins @brtnfld
bin/restore deleted checked-in files (HDFGroup#5017)
6d3585c 
This was not fixed when we started checking in files that were
generated by the Perl scripts in bin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @byrnHDF @mattjala