Set C11 standard in CMake examples #5014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoklee
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
approved these changes
Oct 26, 2024
byrnHDF
requested changes
Oct 26, 2024
| @@ -31,13 +31,13 @@ macro (BASIC_SETTINGS varname) | |||
| set (CMAKE_MFC_FLAG 0) | |||
| endif () | |||
|
|
|||
| set (CMAKE_C_STANDARD 99) | |||
| set (CMAKE_C_STANDARD 11) | |||
There was a problem hiding this comment.
The examples need to work for all versions of the library - should this be conditional on the lib version?
There was a problem hiding this comment.
We can leave it at 99. I don't think the current examples do anything special for C11.
| @@ -32,7 +32,7 @@ endif () | |||
| if (CMAKE_CXX_COMPILER_ID STREQUAL SunPro AND CMAKE_CXX_COMPILER_LOADED) | |||
| if (NOT DEFINED CMAKE_CXX${CMAKE_CXX_STANDARD}_STANDARD_COMPILE_OPTION) | |||
| if (NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.13) | |||
| if (NOT CMAKE_CXX_STANDARD OR CMAKE_CXX_STANDARD EQUAL 98) | |||
| if (NOT CMAKE_CXX_STANDARD OR CMAKE_CXX_STANDARD EQUAL 11) | |||
There was a problem hiding this comment.
This is fine for the library.
|
Closed due to consensus at standup. Examples should not require C11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #4975.