Remove version number from h5repack test plugin #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The h5repack test uses an older copy of a plugin from test that appended the version number to group names. The plugin in test was updated to use a fixed string instead, but the h5repack copy wasn't updated. We'll remove this copy and just use the plugin from test after the Autotools are removed.
derobins
added
Priority - 2. Medium ⏹
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
byrnHDF
approved these changes
Oct 25, 2024
lrknox
reviewed
Oct 26, 2024
| /* | ||
| * Purpose: Tests the plugin module (H5PL) | ||
| * Purpose: Test group filter plugin for the filter_pluging.c test. |
There was a problem hiding this comment.
Suggested change
| * Purpose: Test group filter plugin for the filter_pluging.c test. | |
| * Purpose: Test group filter plugin for the filter_plugin.c test. |
lrknox
approved these changes
Oct 26, 2024
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The h5repack test uses an older copy of a plugin from test that appended the version number to group names. The plugin in test was updated to use a fixed string instead, but the h5repack copy wasn't updated.
We'll remove this copy and just use the plugin from test after the Autotools are removed.