Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TRUE and FALSE from H5private.h #4969

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Remove TRUE and FALSE from H5private.h #4969

merged 2 commits into from
Oct 18, 2024

Conversation

derobins
Copy link
Member

No description provided.

@derobins derobins added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - C Library Core C library issues (usually in the src directory) Component - High-Level Library Code in the hl directory Component - C++ C++ wrappers Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Merge - To 2.0 labels Oct 18, 2024
@derobins
Copy link
Member Author

derobins commented Oct 18, 2024 •
edited
Loading

We purged hbool_t/TRUE/FALSE in lieu of bool/true/false a long time ago. There's no reason to keep TRUE/FALSE macros around (though note that Windows still defines them in Win32).

@derobins derobins merged commit 1c23395 into HDFGroup:develop Oct 18, 2024
60 checks passed
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@derobins @brtnfld
Remove TRUE and FALSE from H5private.h (HDFGroup#4969)
c821b49 
* Remove TRUE and FALSE from H5private.h

* Replace hbool_t with bool in test code
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Nov 4, 2024
@derobins @brtnfld
Remove TRUE and FALSE from H5private.h (HDFGroup#4969)
9b62750 
* Remove TRUE and FALSE from H5private.h

* Replace hbool_t with bool in test code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@qkoziol qkoziol qkoziol approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Component - C++ C++ wrappers Component - High-Level Library Code in the hl directory Component - Testing Code in test or testpar directories, GitHub workflows Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derobins @qkoziol @byrnHDF @mattjala