Fixes a segfault in h5dump #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The B-tree node level was corrupted, resulting in a segfault later. This PR adds a check to detect when the node level is greater than the number of entries and issue an error instead. Fixes HDFGroupGH-4432
bmribler
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
glennsong09,
mattjala and
brtnfld
as code owners
byrnHDF
approved these changes
Sep 20, 2024
qkoziol
approved these changes
Sep 20, 2024
fortnern
approved these changes
Sep 20, 2024
bmribler
added
Merge - To 1.14
Priority - 2. Medium ⏹
qkoziol
pushed a commit
to qkoziol/hdf5
that referenced
this pull request
Oct 1, 2024
* Fixes a segfault in h5dump The B-tree node level was corrupted, resulting in a segfault later. This PR adds a check to detect when the node level is greater than the number of entries and issue an error instead. Fixes HDFGroupGH-4432
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Oct 2, 2024
* Fixes a segfault in h5dump The B-tree node level was corrupted, resulting in a segfault later. This PR adds a check to detect when the node level is greater than the number of entries and issue an error instead. Fixes HDFGroupGH-4432
lrknox
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Fixes a segfault in h5dump The B-tree node level was corrupted, resulting in a segfault later. This PR adds a check to detect when the node level is greater than the number of entries and issue an error instead. Fixes GH-4432
bmribler
added a commit
to bmribler/hdf5_bmr23
that referenced
this pull request
Oct 24, 2024
Added another argument, expected node level, to H5B__iterate_helper to pass down to H5B__cache_deserialize for checking the decoded node level. When this expected level is not known, the new macro H5_UNKNOWN_NODELEVEL (-1) will be used for not checking the level. Fixes HDFGroupGH-4432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h5dump produced a segfault on a mal-formed file because a B-tree node level was corrupted.
This PR adds a check to detect when the node level is greater than the number of entries and to issue an error instead.
Fixes GH-4432