Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last H5E_BEGIN/END_TRY from library code #4694

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Remove last H5E_BEGIN/END_TRY from library code #4694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daa11f9
Drop H5E_BEGIN/END_TRY and just check the error return from H5I_clear…
qkoziol Jul 29, 2024
4c4a8ed
Merge remote-tracking branch 'origin/develop' into pause_errors_7
qkoziol Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/H5Iint.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,8 @@ H5I__destroy_type(H5I_type_t type)
HGOTO_ERROR(H5E_ID, H5E_BADGROUP, FAIL, "invalid type");

/* Close/clear/destroy all IDs for this type */
H5E_BEGIN_TRY
{
H5I_clear_type(type, true, false);
}
H5E_END_TRY /* don't care about errors */
if (H5I_clear_type(type, true, false) < 0)
HGOTO_ERROR(H5E_ID, H5E_CANTRELEASE, FAIL, "unable to release IDs for type");

/* Check if we should release the ID class */
if (type_info->cls->flags & H5I_CLASS_IS_APPLICATION)
Expand Down
Loading