Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for H5R get name APIs #4657

Merged
merged 11 commits into from
Aug 12, 2024
Merged

Add tests for H5R get name APIs #4657

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c95412
Add tests for H5R get name APIs
bmribler Jul 17, 2024
0756fc0
Committing clang-format changes
github-actions[bot] Jul 17, 2024
f5690de
Fix typo
bmribler Jul 17, 2024
60e3698
Merge branch 'fix_GH-4447' of https://github.com/bmribler/hdf5_bmr23 …
bmribler Jul 17, 2024
49404be
Fix typo
bmribler Jul 17, 2024
a596716
Fix Fortran test
bmribler Jul 17, 2024
92e5af3
Merge branch 'develop' of https://github.com/HDFGroup/hdf5 into fix_G…
bmribler Jul 29, 2024
9d57f6a
Add test H5Aget_name against H5Rget_attr_name
bmribler Aug 11, 2024
8be015a
Committing clang-format changes
github-actions[bot] Aug 11, 2024
da125e2
Update documentation
bmribler Aug 12, 2024
6edb92a
Fix typo
bmribler Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions fortran/src/H5Rff.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,8 +1180,6 @@ END FUNCTION H5Rget_attr_name
c_name(1:1)(1:1) = C_NULL_CHAR
name_len = H5Rget_attr_name(ref_ptr, c_name, 1_SIZE_T)
IF(name_len.LT.0_SIZE_T) hdferr = H5I_INVALID_HID_F
! Don't include the NULL term in the size
name_len = name_len - 1
Copy link
Contributor

@brtnfld brtnfld Jul 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, H5Rget_attr_name returned length does not include the NULL character now with this PR? If that is the case, the doxygen doc needs to be updated as it says it does include NULL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ELSE
l = INT(LEN(name)+1,SIZE_T)
IF(H5Rget_attr_name(ref_ptr, c_name, l) .LT. 0_SIZE_T)THEN
Expand Down
2 changes: 1 addition & 1 deletion src/H5Rint.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ H5R__get_attr_name(const H5R_ref_priv_t *ref, char *buf, size_t size)
buf[copy_len] = '\0';
}

ret_value = (ssize_t)(attr_name_len + 1);
ret_value = (ssize_t)(attr_name_len);

FUNC_LEAVE_NOAPI(ret_value)
} /* end H5R__get_attr_name() */
Expand Down
Loading
Loading