Report build options of VFDs #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtnfld
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
|
So would it be something like this to reset it if the option fails? set (HDF5_ENABLE_MIRROR_VFD OFF CACHE BOOL "Build the Mirror Virtual File Driver" FORCE) |
Yes, we'd need to add lines like that in all the places where a feature gets disabled for some reason. Some refactoring of the CMake logic may be needed to make that not too ugly. |
hyoklee
approved these changes
Apr 2, 2024
lrknox
approved these changes
Apr 2, 2024
byrnHDF
approved these changes
Apr 2, 2024
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Apr 3, 2024
* changed to if string contains instead * return status of VFDs in libhdf5.settings * use *_ENABLE_* settings instead to report the state * added map state * updated resetting status if cmake option fails
lrknox
added a commit
that referenced
this pull request
Apr 3, 2024
* Fix divide-by-zero when page buf page size is 0 (#4296) If a corrupt file sets the page buffer size in the superblock to zero, the library could attempt to divide by zero when allocating space in the file. The library now checks for valid page buffer sizes when reading the superblock message. Fixes oss-fuzz issue 58762 * Fix typo - Cnversion (#4301) * Bump the github-actions group with 3 updates (#4300) Bumps the github-actions group with 3 updates: [actions/download-artifact](https://github.com/actions/download-artifact), [softprops/action-gh-release](https://github.com/softprops/action-gh-release) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/download-artifact` from 4.1.1 to 4.1.4 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4.1.1...c850b93) Updates `softprops/action-gh-release` from 1 to 2 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@de2c0eb...9d7c94c) Updates `github/codeql-action` from 3.24.6 to 3.24.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8a470fd...1b1aada) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix typo - glueing (#4299) * Prepend MPI_TEST_ to parallel example test names (#4306) * Report build options of VFDs (#4304) * changed to if string contains instead * return status of VFDs in libhdf5.settings * use *_ENABLE_* settings instead to report the state * added map state * updated resetting status if cmake option fails * PR merge workflows (#4303) * Merge the Test Express workflows into the PR CI * Split merge request triggers into autotools vs cmake * Fix typo - differetly (#4311) * Fix README badges (#4313) * Remove old wait_H5Tinit.cmake file (#4314) * Update branch names: develop=>hdf5_1_14 in 2 new workflows merged from develop.
qkoziol
pushed a commit
to qkoziol/hdf5
that referenced
this pull request
Apr 8, 2024
* changed to if string contains instead * return status of VFDs in libhdf5.settings * use *_ENABLE_* settings instead to report the state * added map state * updated resetting status if cmake option fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.