Sync develop changes March 20 - March 25 to hdf5_1_14. #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffers passed to stat-like calls are only partially filled in by the call, leaving ununitialized memory areas when the stat buffers are created on the stack. This change memsets the buffers to 0 before the stat calls, quieting the -fsanitze=memory complaints.
* Suggested header footer for NEWSLETTER * Updates * Add NEWSLETTER.txt to h5vers script
…p#4194) * Fix issue with Subfiling VFD and multiple opens of same file * Update H5_subfile_fid_to_context to return error value instead of ID * Add helper routine to initialize open file mapping
We previously replaced local macros with AC_SYS_LARGEFILE, which is unfortunately buggy on some systems and does not correctly set the necessary defines, despite successfully detecting them. This restores the previous macro hacks to acsite.m4
…tion flags (HDFGroup#4209) * addressed issue wit promoted integers and reals * added option to use mpi_f08
Also removed Copyright.html context because it's no longer valid.
Changes Autotools testing to use HDF5_TEST_DRIVER environment variable to avoid running tests that don't work well with several VFDs Restores old h5_get_vfd_fapl() testing function to setup a FAPL with a particular VFD Adds a macro for the default VFD name
… compil…" (HDFGroup#4220) This reverts commit 06c42ff.
Fixes HDFGroupGH-3881 partially. There are pages that need to be recreated.
If the library tries to load a metadata object that is above the library's hard-coded limits, the size will trip an assert in debug builds. In HDF5 1.14.4, this can happen if you create a very large number of links in an old-style group that uses local heaps. The library will now emit a normal error when it tries to load a metadata object that is too large. Partially addresses GitHub HDFGroup#3762
…tion flags, part 2 (HDFGroup#4221) * addressed issue wit promoted integers and reals * fixed h5fcreate_f * added option to use mpi_f08 * change the kind of logical in the parallel tests * addressed missing return value from callback
When building with debug symbols on MacOS, the cp -p commands in test_plugin.sh will attempt to copy the .dSYM directories with debugging info, which will fail since -r is missing. Using cp -rp is harmless and allows the test to run Fixes HDFFV-10542
lrknox
requested review from
jhendersonHDF,
byrnHDF,
derobins,
brtnfld,
epourmal,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
bmribler
approved these changes
Mar 25, 2024
| /******/ | ||
| { | ||
| int ret_value = -1; | ||
| hid_t c_prp_id; | ||
| herr_t ret; | ||
| MPI_Comm c_comm; | ||
| MPI_Info c_info; | ||
| c_comm = MPI_Comm_f2c(*comm); | ||
| c_info = MPI_Info_f2c(*info); | ||
| c_comm = MPI_Comm_f2c(*((int *)comm)); |
There was a problem hiding this comment.
Not at all relevant to this PR, but @brtnfld it seems problematic to always assume here that int converts to MPI_Fint
byrnHDF
reviewed
Mar 25, 2024
|
Needed the branch name hdf5_1_14.
________________________________
From: Allen Byrne ***@***.***>
Sent: Monday, March 25, 2024 4:30 PM
To: HDFGroup/hdf5 ***@***.***>
Cc: Larry Knox ***@***.***>; Author ***@***.***>
Subject: Re: [HDFGroup/hdf5] Sync develop changes March 20 - March 25 to hdf5_1_14. (PR #4241)
@byrnHDF commented on this pull request.
________________________________
In release_docs/USING_HDF5_CMake.txt<#4241 (comment)>:
@@ -234,7 +234,7 @@ adjust the forward slash to double backslashes, except for the HDF_DIR
environment variable.
NOTE: this file is available in the HDF5 repository, for more information see:
- https://github.com/HDFGroup/hdf5/blob/develop/release_docs/USING_CMake_Examples.txt
+ https://github.com/HDFGroup/hdf5/blob/v1_14/release_docs/USING_CMake_Examples.txt
Check in hdf5 repo for it. Maybe URL needs to be edited.
—
Reply to this email directly, view it on GitHub<#4241 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCXDSRZQPUD7KZ3VPILY2CJQNAVCNFSM6AAAAABFHUFQS2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJYHAYTSMBXGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
byrnHDF
approved these changes
Mar 25, 2024
jhendersonHDF
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.