Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows CI to not install ninja #4230

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update Windows CI to not install ninja #4230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/main-cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ jobs:

# CMake gets libaec from fetchcontent

- name: Install Dependencies (Windows)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe - Ninja will be needed if we want to use clang (like OneAPI, it is needed for alternative compilers on windows). Note that ninja is required for the binary tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be cautious about what checks are required for PRs if they're going to go out and grab things from the internet outside of what's the default on runners. Testing alternative compilers on Windows is great, but probably doesn't need to be a required check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clang and OneAPI on windows are just as important as those compilers for linusx, right?
Unfortunately GH actions for testing are problematic at any time and chocaoately isn't necessarily worse then anything else being used.
The more important metric is time for PRs S.B. less than 25 mins for a workflow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe main-cmake.yml would be better named main-cmake-vs.yml or vs-cmake.yml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least we should be able to keep a cached installation of ninja and other required things around when we've gotten them once. It also doesn't seem like Ninja is used anywhere for the binary tests. It seems like just the OneAPI Windows action is using it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also look at https://cmake.org/cmake/help/latest/variable/CMAKE_GENERATOR_TOOLSET.html. Seems like we can use clang and possibly OneAPI as well with VS generators so that we don't need ninja in the first place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bintest definitely uses ninja as the generator.

run: choco install ninja
if: matrix.os == 'windows-latest'

- name: Install Dependencies (macOS)
run: brew install ninja
if: matrix.os == 'macos-13'
Expand Down
Loading