Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 10 merges from develop #419

Merged
merged 27 commits into from
Mar 3, 2021
Merged

1 10 merges from develop #419

merged 27 commits into from
Mar 3, 2021

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Mar 3, 2021

#358 patches from vtk
#361 fix header guard spelling

#358 patches from vtk
#361 fix header guard spelling
#358 patches from vtk
#361 fix header guard spelling
@byrnHDF byrnHDF added the bug label Mar 3, 2021
@byrnHDF byrnHDF self-assigned this Mar 3, 2021
@byrnHDF byrnHDF requested review from bmribler and brtnfld as code owners March 3, 2021 14:43
@byrnHDF
Copy link
Contributor Author

byrnHDF commented Mar 3, 2021

I need help finding the error;
In file included from /home/byrn/HDF_Projects/hdf5/1.10/src/H5Fprivate.h:25,
from /home/byrn/HDF_Projects/hdf5/1.10/src/H5Bprivate.h:30,
from /home/byrn/HDF_Projects/hdf5/1.10/src/H5Gprivate.h:33,
from /home/byrn/HDF_Projects/hdf5/1.10/src/H5Lprivate.h:25,
from /home/byrn/HDF_Projects/hdf5/1.10/src/H5Plapl.c:37:
/home/byrn/HDF_Projects/hdf5/1.10/src/H5Fpublic.h:78:25: error: initializer element is not constant
78 | #define H5F_ACC_DEFAULT (H5CHECK H5OPEN 0xffffu) /* ignore setting on lapl /
| ^
/home/byrn/HDF_Projects/hdf5/1.10/src/H5Plapl.c:78:34: note: in expansion of macro ‘H5F_ACC_DEFAULT’
78 | #define H5L_ACS_ELINK_FLAGS_DEF H5F_ACC_DEFAULT
| ^~~~~~~~~~~~~~~
/home/byrn/HDF_Projects/hdf5/1.10/src/H5Plapl.c:167:5: note: in expansion of macro ‘H5L_ACS_ELINK_FLAGS_DEF’
167 | H5L_ACS_ELINK_FLAGS_DEF; /
Default file access flags for external link traversal */
| ^~~~~~~~~~~~~~~~~~~~~~~

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Mar 3, 2021

src/H5Fpublic.h and src/H5private.h are the only files I can find with possible source changes that are involved with the error.
All the other file changes are mostly the elimination of the double underscore #ifndef guards.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Mar 3, 2021

Fixed! H5Ppublic.h - missed a underscore in an include guard:
#undef H5OPEN
#ifndef H5private_H <----------
#define H5OPEN H5open(),
#else /* H5private_H /
#define H5OPEN
#endif /
H5private_H */

@byrnHDF byrnHDF added merge and removed bug labels Mar 3, 2021
@lrknox lrknox merged commit e65814b into HDFGroup:hdf5_1_10 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants