Sync develop branch changes since 2/16 to hdf5_1_14 branch #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced last sprintf with snprintf To have the size of the buffer, it was required to change a function signature, and change all users of it. In most cases, determining the buffer size wasn't trivial and so SIZE_MAX is passed. But at least this improves the infrastructure. Someone can later figure out the correct sizes.
…4031) With MPI 4.1 the use of the mpif.h include file has been deprecated. Codes should transition to USE mpi or USE mpi_f08. Signed-off-by: Christoph Niethammer <[email protected]>
H5F_get_access_plist previously did not copy over the file locking settings from a file into the new File Access Property List that it creates. This would make it difficult to match the file locking settings between an external file and its parent file.
Improve performance of flushing a single object, and remove metadata cache flush markers
… flag is used (HDFGroup#4021) When the H5LT_FILE_IMAGE_DONT_COPY flag is passed to H5LTopen_file_image, the internally-allocated udata structure gets leaked as the core file driver doesn't have a way to determine when or if it needs to call the 'udata_free' callback. This has been fixed by freeing the udata structure when the 'image_free' callback gets made during file close, where the file is holding the last reference to the udata structure.
The Autools Classic Intel compiler configuration attempts to load a file named `general-19` from the intel-warnings/classic directory, which does not exist. This removes the attempted load of the file.
The ibm-aix Autotools config file had some unmaintained and unnecessary Autoconf cache overrides. These have been removed.
There are many architecture-specific linux files in the config directory, all of which simply redirect to linux-gnulibc1. This change renames linux-gnulibc1 to linux-gnu and deletes the more specific files.
This is not used in the library
Fixes an issue where the HDF5_USE_FILE_LOCKING environment variable being set can interfere with the file locking setting that the test expects to be returned.
Bumps the github-actions group with 2 updates: [actions/download-artifact](https://github.com/actions/download-artifact) and [github/codeql-action](https://github.com/github/codeql-action).
Fix link API tests with incorrect filename
lrknox
requested review from
brtnfld,
derobins,
epourmal,
byrnHDF,
fortnern and
jhendersonHDF
as code owners
lrknox
requested review from
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
derobins
added
Merge
byrnHDF
approved these changes
Mar 4, 2024
release_docs/INSTALL_CMake.txt
Outdated
| @@ -213,7 +213,7 @@ Notes: This short set of instructions is written for users who want to | |||
| cmake -G "Visual Studio 16 2019" -A Win32 -DCMAKE_BUILD_TYPE:STRING=Release -DBUILD_SHARED_LIBS:BOOL=OFF -DBUILD_TESTING:BOOL=ON -DHDF5_BUILD_TOOLS:BOOL=ON ..\hdf5-1.14."X" | |||
|
|
|||
| On Windows 64 bit | |||
| cmake -G "Visual Studio 16 2019 Win64" -A x64 -DCMAKE_BUILD_TYPE:STRING=Release -DBUILD_SHARED_LIBS:BOOL=OFF -DBUILD_TESTING:BOOL=ON -DHDF5_BUILD_TOOLS:BOOL=ON ..\hdf5-1.14."X" | |||
| cmake -G "Visual Studio 16 2019" -A x64 -DCMAKE_BUILD_TYPE:STRING=Release -DBUILD_SHARED_LIBS:BOOL=OFF -DBUILD_TESTING:BOOL=ON -DHDF5_BUILD_TOOLS:BOOL=ON ..\hdf5-1.15."X" | |||
release_docs/INSTALL_Auto.txt
Outdated
| 4.3.11. Backward compatibility | ||
| The 1.14 version of the HDF5 library can be configured to operate | ||
| 3.11. Backward compatibility | ||
| The 1.15 version of the HDF5 library can be configured to operate |
There was a problem hiding this comment.
Should this sentence be in the 1.14 branch?
There was a problem hiding this comment.
Of course not it should be 1.14 and the next two lines for 1.14 api should be removed
There was a problem hiding this comment.
Better make sure there are no other 1.15 refs in the PR!
There was a problem hiding this comment.
There are 3 more of them in HDF5Examples/CMakeUserPresets.json lines 22 - 27:
"environment": {
"HDF5_ROOT": "${sourceParentDir}/temp/HDF_Group/HDF5/1.15.0",
"HDF5_PLUGIN_PATH": "${sourceParentDir}/temp/HDF_Group/HDF5/1.15.0/lib/plugin"
},
"cacheVariables": {
"HDF5_ROOT": {"type": "STRING", "value": "${sourceParentDir}/temp/HDF_Group/HDF5/1.15.0"},
They were already there in the hdf5_1_14 branch. I'll change them to 1.14.4, but @byrnHDF do we need to add the file/lines to h5vers?
jhendersonHDF
approved these changes
Mar 4, 2024
byrnHDF
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.