Develop merge examples #3851
Develop merge examples #3851
Conversation
byrnHDF
added
Priority - 2. Medium ⏹
byrnHDF
requested review from
jhendersonHDF,
derobins,
brtnfld,
epourmal,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
| # Option to Enable MPI Parallel | ||
| #----------------------------------------------------------------------------- | ||
| set (CMAKE_MODULE_PATH ${H5EXAMPLES_RESOURCES_DIR} ${CMAKE_MODULE_PATH}) | ||
| option (HDF_ENABLE_PARALLEL "Enable parallel build (requires MPI)" OFF) |
There was a problem hiding this comment.
Looks like this CMakeLists file needs to be updated to use the options that are already in the library (ENABLE_PARALLEL, ENABLE_THREADSAFE, BUILD_FORTRAN, BUILD_JAVA). Otherwise, we're bringing in duplicate options.
There was a problem hiding this comment.
So, this would be true if I didn't also need to provide a standalone copy in the binaries that could could be used to verify the install as well as provide workable examples.
HDF5Examples/configure
Outdated
There was a problem hiding this comment.
Should a generated configure file be checked in here?
There was a problem hiding this comment.
That is because of the way the autotools were initially implemented. Someone will need to remove all the generated files and implement an autoconfig solution.
There was a problem hiding this comment.
When I add my examples, I'll see if I can make it look more like C's output. Are you ignoring white space and new lines when comparing the output?
There was a problem hiding this comment.
newlines - definitely, Possibly not anything else.
doxygen/Doxyfile.in
Outdated
| @@ -733,6 +733,7 @@ EXCLUDE_PATTERNS += */hl/fortran/examples/* | |||
| EXCLUDE_PATTERNS += */hl/fortran/test/* | |||
| EXCLUDE_PATTERNS += */hl/fortran/src/*.c | |||
| EXCLUDE_PATTERNS += */hl/fortran/src/*.h | |||
| EXCLUDE_PATTERNS += */HDF5Examples/FORTRAN/H5T/* | |||
There was a problem hiding this comment.
You can exclude all files in */HDF5Examples/FORTRAN
|
We should rename the H5P directory to H5Parallel. |
|
Unforyunately - no because I run into path lenght issues on some platforms and CI. |
|
I don't understand. Is that an HDF5 issue? Can we at least use H5PAR? I can look into it more if you are out of hours. I just need to get an idea of what to look into. |
Sure - two letters should be fine. |
NOTE: goal is to have one folder with examples that can be distributed with the library source as well as be distributed with an installation/binary that can be used standalone with an installed hdf5.
CMake workflows integrated into library.
Autotools scripts updated with correct directory paths for reference files (not tested, not integrated with library configure)