Add GitHub actions for testing VOL connectors #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for testing external passthrough VOL connector with API tests
While previously necessary, it now interferes with VOL connectors that may need to be initialized with MPI_THREAD_MULTIPLE
jhendersonHDF
added
Merge - To 1.14
Priority - 2. Medium ⏹
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF and
fortnern
as code owners
jhendersonHDF
requested review from
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
jhendersonHDF
commented
Nov 13, 2023
| MPI_Comm_rank(MPI_COMM_WORLD, &mpi_rank_g); | ||
| #ifdef H5_HAVE_TEST_API | ||
| /* Attempt to initialize with MPI_THREAD_MULTIPLE if possible */ | ||
| if (MPI_SUCCESS != (mpi_code = MPI_Init_thread(&argc, &argv, required, &provided))) { |
There was a problem hiding this comment.
If doing API testing, try to initialize parallel tests with maximum thread safety support since some VOL connectors like the Async and Cache VOL require this. Otherwise, just do a regular MPI_Init since MPI_Init_thread with MPI_THREAD_MULTIPLE can have performance consequences.
mattjala
approved these changes
Nov 14, 2023
byrnHDF
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds actions for testing the following VOL connectors: