Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmakedefine macro uses C comments with "#undef" #3845

Merged
merged 3 commits into from
Nov 13, 2023
Merged

cmakedefine macro uses C comments with "#undef" #3845

merged 3 commits into from
Nov 13, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Nov 13, 2023

No description provided.

@byrnHDF byrnHDF added Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Fortran Fortran wrappers Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub labels Nov 13, 2023
@byrnHDF byrnHDF self-assigned this Nov 13, 2023
@lrknox
Copy link
Collaborator

lrknox commented Nov 13, 2023

Change fixed compile failure on vortex (ppc64le @ sandia) with clang 14.0.4

brtnfld
brtnfld approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine, but I don't think we use C_SIZEOF anymore. I can address that in a separate PR.

@lrknox lrknox merged commit 378e990 into HDFGroup:develop Nov 13, 2023
45 checks passed
@byrnHDF byrnHDF deleted the develop-fort-config branch November 13, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@brtnfld brtnfld brtnfld approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@epourmal epourmal Awaiting requested review from epourmal epourmal is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Fortran Fortran wrappers Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @lrknox @brtnfld